Skip to content

feat(wren-ui): add adjust the answer dropdown for answer tab#1479

Merged
andreashimin merged 1 commit intoepic/adjust-answerfrom
feat/adjust-answer-dropdown
Mar 28, 2025
Merged

feat(wren-ui): add adjust the answer dropdown for answer tab#1479
andreashimin merged 1 commit intoepic/adjust-answerfrom
feat/adjust-answer-dropdown

Conversation

@fredalai
Copy link
Copy Markdown
Contributor

@fredalai fredalai commented Mar 28, 2025 •
edited
Loading

Description

This PR introduced a new AdjustAnswerDropdown component to handle additional dropdown actions like "Adjust steps" and "Adjust SQL".

Here we just add the common UI components first, and the implementation will be completed through other PRs

Task

  • Add adjust the answer dropdown

UI

截圖 2025-03-28 上午10 21 22
截圖 2025-03-28 上午10 20 29

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 28, 2025 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@fredalai fredalai marked this pull request as ready for review March 28, 2025 02:22
@fredalai fredalai changed the title feat(wren-ui): adjust the answer dropdown feat(wren-ui): add adjust the answer dropdown for answer tab Mar 28, 2025
Copilot AI reviewed Mar 28, 2025
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new AdjustAnswerDropdown component to the answer tab for supporting additional actions ("Adjust steps" and "Adjust SQL") in the UI.

  • Introduces a new EditSVG component for iconography in dropdowns.
  • Creates a dedicated dropdown action enum and a custom hook (useDropdown) for managing dropdown visibility.
  • Updates TextBasedAnswer and CustomDropdown components to integrate the new dropdown functionality.

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
wren-ui/src/utils/svgs/index.ts Added export for the new EditSVG component
wren-ui/src/utils/svgs/EditSVG.tsx New SVG component for the edit icon
wren-ui/src/utils/enum/modeling.ts Removed the obsolete MORE_ACTION enum
wren-ui/src/utils/enum/index.ts Added export for the new dropdown enum
wren-ui/src/utils/enum/dropdown.ts New enum listing dropdown actions including adjust actions
wren-ui/src/hooks/useDropdown.tsx New hook to manage dropdown visibility
wren-ui/src/components/pages/home/promptThread/TextBasedAnswer.tsx Integrated AdjustAnswerDropdown and updated dropdown state handling
wren-ui/src/components/diagram/CustomDropdown.tsx Extended dropdown to support adjust actions via AdjustAnswerDropdown

@andreashimin andreashimin merged commit f90f268 into epic/adjust-answer Mar 28, 2025
2 checks passed
@andreashimin andreashimin deleted the feat/adjust-answer-dropdown branch March 28, 2025 03:24
fredalai added a commit that referenced this pull request Apr 1, 2025
@fredalai
feat(wren-ui): add adjust the answer dropdown for answer tab (#1479)
796db9d
@andreashimin andreashimin mentioned this pull request Apr 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@andreashimin andreashimin andreashimin approved these changes

Assignees

No one assigned

Labels

wren-ui

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fredalai @andreashimin